search

morenoh149 / react-native-contacts

React Native Contacts
MIT License
1.64k stars 560 forks source link

UIBarButtons on iOS nearly invisible when using "open contact form" in dark mode. #639

Closed ojhansson closed 2 years ago

ojhansson commented 3 years ago

It's almost impossible to see the "Cancel" and "Done" buttons as you can see in the image below.

image

nateguy commented 2 years ago

I'm having the same issue too

elrony commented 2 years ago

Another issue is that the navigation bar's tint colour is changed to be black, so if your app has a custom navigation bar the colour is replaced when the contact screen is presented and, when closed, it never goes back to its original colour.

I have tried removing the lines from 680-688 to let iOS deal with dark mode and it all works as expected.

Here for openContactForm: https://github.com/morenoh149/react-native-contacts/blob/f74d3545405447fa61ad37c69a2418fc411a3b93/ios/RCTContacts/RCTContacts.m#L680

And here too for editExistingContact: https://github.com/morenoh149/react-native-contacts/blob/f74d3545405447fa61ad37c69a2418fc411a3b93/ios/RCTContacts/RCTContacts.m#L863

From iOS 13 on all system "modals" automatically use dark/light mode. I have tested this on iOS 13/14/15 and it works correctly on all of them.

Should these lines be removed?