search

morenoh149 / react-native-contacts

React Native Contacts
MIT License
1.64k stars 560 forks source link

Month inconsistencies between iOS and Android #641

Closed ejoncas-rivalbet closed 2 years ago

ejoncas-rivalbet commented 3 years ago

iOS substracts -1 to the month to make it zero-indexed.

https://github.com/morenoh149/react-native-contacts/blob/master/ios/RCTContacts/RCTContacts.m#L346

But then Android does not https://github.com/morenoh149/react-native-contacts/blob/master/android/src/main/java/com/rt2zz/reactnativecontacts/ContactsProvider.java#L541

I think we should make it consistent. My preference is to keep 1-indexed months to keep it consistent with day and year fields.

github-actions[bot] commented 2 years ago

This issue is stale, please provide more information about the status

morenoh149 commented 2 years ago

still a good first issue.