search

morenoh149 / react-native-contacts

React Native Contacts
MIT License
1.65k stars 564 forks source link

Add a field to indicate if the contact is starred #666

Closed johnf closed 2 years ago

johnf commented 2 years ago

Note: This only works on Android as Apple doesn't provide this information :(

I read CONTRIBUTING.md after I created the patch, so not sure if you will want to merge this given it is Android only.

Fixes #90

morenoh149 commented 2 years ago

is there a way to add this so that it makes sense to ios users?

johnf commented 2 years ago

I don't think so. From what I've found online, on iOS the star capability is part of the contacts app and not the API, so isn't accessible by other applications.

johnf commented 2 years ago

@morenoh149 any interest in this or should I close it?

morenoh149 commented 2 years ago

I think we need to add two new sections to the readme, ios only and android only where we detail things that are only available for one platform. Add that to the readme and I'll merge this.

johnf commented 2 years ago

@morenoh149 I've added something in. I've given you edit permissions to this PR so you can make changes as needed

morenoh149 commented 2 years ago

there are some ios and android only things, I added them to the new readme section.

yanivbs commented 2 years ago

Hi, I don't have any solution for this yet, but if you feel the need to close it then close.

--

B.R

Yaniv Ben shetrit

Cell: 053-7276021

E-mail: @.***

בתאריך יום ד׳, 15 ביוני 2022, 11:32, מאת John Ferlito ‏< @.***>:

@morenoh149 https://github.com/morenoh149 any interest in this or should I close it?

— Reply to this email directly, view it on GitHub https://github.com/morenoh149/react-native-contacts/pull/666#issuecomment-1156164072, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOFLHGURQXJY55FLPVZQB3LVPGIIPANCNFSM5SYPKGEQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>