search

morenoh149 / react-native-contacts

React Native Contacts
MIT License
1.65k stars 564 forks source link

Migrate to new Arch #739

Closed hoanghai9650 closed 1 month ago

hoanghai9650 commented 6 months ago

Migrate library to new Arch of React Native.

jannisringwald commented 6 months ago

I'm getting the Error while building you Branch:

Undefined symbols for architecture arm64: "_OBJC_CLASS_$_CNContactViewController", referenced from: in react_native_contacts[3](RCTContacts.o) ld: symbol(s) not found for architecture arm64

hoanghai9650 commented 6 months ago
Screenshot 2024-05-21 at 17 05 32

Have you set arm64 in excluded Architectures in Build Settings?

morenoh149 commented 6 months ago

@hoanghai9650 thanks for this. Does this close #736 ?

hoanghai9650 commented 5 months ago

@morenoh149 Yes, this PR will close that issue

mym0404 commented 5 months ago

@hoanghai9650 why should we exclude arm64 architecture? It seems not an idle solution.

hoanghai9650 commented 5 months ago

@mym0404 As you can see in my code, I didn't config or enable any arm64, but don't know why this new arch required that, I think because of new Spec of React Native. But with all libs that I migrated to new arch, I also have to enable arm64 to make it run.

mym0404 commented 5 months ago

It makes sense. But, the build will success with manually add Contacts apple sdk in app target.

I'll further investigate why new arch made change.

github-actions[bot] commented 3 months ago

This Pull request is stale, please review.

morenoh149 commented 2 months ago

@hoanghai9650 new conflicts

SolankiYogesh3500 commented 2 months ago

new update on this guys ?

faljabi commented 2 months ago

Hi,

When this will be merged? app is crashing for new Arch.