morepath / morepath_cerebral_todomvc

Cerebral TodoMVC with a Morepath REST backend.
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Fix travis #4

Closed jugmac00 closed 4 years ago

jugmac00 commented 4 years ago

Although travis is green, both Python 3.6 and Python 3.7 are not run at all as the interpreter are missing. https://travis-ci.org/github/morepath/morepath_cerebral_todomvc

Todo Use a matrix, see https://github.com/morepath/morepath_static/pull/4 how to fix it.

Aniruddha-Shriwant commented 4 years ago

Well @jugmac00 , I would like to work on it :)

jugmac00 commented 4 years ago

I heard you have experience with it :-)

Thanks, please go for it!

rajchordia14 commented 4 years ago

can i work on the issue?

jugmac00 commented 4 years ago

Hi @rajchordia14 - @Aniruddha-Shriwant was a bit faster on this one.

But there are many similar issues to go for. Have a look at any of those https://github.com/search?q=org%3Amorepath+Update+supported+Python+versions&type=issues

Aniruddha-Shriwant commented 4 years ago

Well @jugmac00 , I had done with my 4 PR's for the Hacktoberfest, Thanks for guiding me from the beginning, will keep exploring new things as I did in this organization's repositories :)

jugmac00 commented 4 years ago

fixed by #5

jugmac00 commented 4 years ago

@Aniruddha-Shriwant Good luck for your future! :-)

Aniruddha-Shriwant commented 4 years ago

Hey @jugmac00 , I think Hacktoberfest has new rules now, PR won't count if the repo is not participated in Hacktoberfest and in order to participate in Hacktoberfest, the maintainers should add the Hacktoberfest topic to their repo image

jugmac00 commented 4 years ago

Hi @Aniruddha-Shriwant no worries. The new rules only apply to PRs after Oct 3 - the PRs until then remain valid.