morerokk / IreNFist

A continuation/fix of the IreNFist mod for PAYDAY 2
MIT License
4 stars 2 forks source link

Reload while sprinting/Parkour Aced and Lock and Load animation bugs #40

Open ghost opened 3 years ago

ghost commented 3 years ago

The first bug can occur whenever I cancel the reloading while sprinting and is quite common. The sprinting animation stops if I sprint or shoot again, as you can see in the video. This doesn't happen if I don't have Parkour skill Aced.

The second bug triggers the Lock and Load animation/Hip fire sprinting animation, even though I don't have the skill. And it is quite rare and was difficult to reproduce. Both bugs happen with every weapon available in the game.

I tried removing some mods that might be the perpetrator of those bugs, but the problem still persists. It would be great if you can look further into this. Thank you.

morerokk commented 3 years ago

Thanks for the detailed report with video, it's very much appreciated! I'll get on fixing this.

ghost commented 3 years ago

I'm glad to help or report. Thank you for your response.

morerokk commented 3 years ago

Interesting, looks like this can only happen as soon as either half or all of the reload timer has elapsed (and the animation hasn't finished playing yet). Happens as soon as bullets into your mag get refilled. This might be a tricky one.

morerokk commented 3 years ago

This should now be fixed.

morerokk commented 3 years ago

I still get the issue sometimes but not in a way I can easily reproduce. If you can find a specific way it would be appreciated.

Either way the issue seems FAR rarer now.

ghost commented 3 years ago

Two possibilities here:

  1. On the first video and at 33 seconds mark, instead of playing the reload animation while sprinting, it played the normal sprinting animation instead. And the animation gets stuck until I either shoot or sprint again. This occurs rarely, and it was difficult for me to reproduce as well.
  2. It's difficult for me to explain and pinpoint without a video, but I've recorded several clips with (at least) coherent explanations inside. I will upload them soon.

Note that this issue doesn't occur without the mod.

ghost commented 3 years ago

The video is currently on upload and the bugs may be tricky, but I've managed to reproduce them. I already explained the bug in those clips, but I'll say here anyway.

In vanilla Payday 2, if you have Parkour Aced skill, there are three animation's "switches" or phases:

  1. Reload animation
  2. Static animation
  3. Sprint animation The bug occurs if you release the sprint key on the second animation, or a few seconds after the reload animation. This is why it's likely difficult to reproduce since the second animation plays for like, milliseconds, but I've included a freeze-frame and a slow-motion in the video for this one.

If you keep holding the sprint button or if you stop sprinting before the reload animation finishes, the bug will not happen.

ghost commented 3 years ago

Here's the video: https://www.youtube.com/watch?v=ETP5MFkx9K4 I apologize for the poor editing and/or quality, but I hope it's adequate to narrow it down.

morerokk commented 3 years ago

This is proving to be a bit harder to fix than I thought. I'm still working on it, but I may have to drop the priority just a tad since it's harder to trigger now and isn't gamebreaking.

ghost commented 3 years ago

Yeah, it's perfectly fine and fair--not to mention the sprinting bug only occurs if you have Parkour skill Aced.

ghost commented 3 years ago

I've found a way to reproduce the Lock and Load animation bug, but you have to be (somehow) precise; The bug occurs if you press and hold the sprint key as soon as the reload finishes. Here's a video of the example: https://youtu.be/qAVUzi6iKXg

Edit: I stand corrected. Both issues seem to occur only if you have Parkour skill Aced.

morerokk commented 3 years ago

I've done quite a bit of testing in the code so far, but no luck actually fixing it. InF doesn't/shouldn't touch anything related to the stances anymore, other than allowing running while holding melee.

ghost commented 3 years ago

A bit old, but it seems that running while holding melee can trigger the Lock and Load animation bug.

ghost commented 3 years ago

A new note: This doesn't happen on the weapons from the Gunslinger Pack.