search

morerokk / IreNFist

A continuation/fix of the IreNFist mod for PAYDAY 2
MIT License
4 stars 2 forks source link

Sydch' Skill Overhaul (SSO) Compatibility issues #75

Closed MrVavlo closed 3 years ago

MrVavlo commented 3 years ago

Yus, I'm still here (⌒_⌒;) Just a question, not a request - since I wanted to try the Guardian until realised that I can't do it with SSO - What will happen with it from now on? And if you will still support it - should I (we?) expect compatibility changes before SSO get an update, or later?

morerokk commented 3 years ago

I wanted to test it without SSO first. SSO support will come very soon.

I generally play without SSO and I have to remake my builds every time I switch, so I tend to backup my saves, work on SSO compatibility, then switch back.

MrVavlo commented 3 years ago

Oh, I see. Well, if anything needed from a SSO player - feel free to ask.

At the same time, I'll check out the new assaults...

morerokk commented 3 years ago

SSO is now compatible with the Guardian perk deck. The other skill changes are already in SSO in some way (Moving Target, stockholm syndrome etc), so I'm not touching those.

However, the second card in a perk deck no longer increases headshot damage by 30%. Must have missed that one last time.

MrVavlo commented 3 years ago

I think it's better to update this issue instead of creating the new one.

Last update of SSO partly broke the compatibility (who would expect, huh): some skills have old descriptions despite having new skills attached - for example, Marksman (which was moved to Tier 1) have removed movement penalty while aiming/increased zoom level in-game, while skill description have old bonuses aka "on paper" (increased zoom level and sniper rifles' reload speed/increased AR and SMG reload speed; which were true before the SSO update)

morerokk commented 3 years ago

SSO has had a pretty big update so I'll probably have to redo most of the compatibility. Not a really big issue but something I'll have to look at. Thanks for the report!

Olivefromspace commented 3 years ago

Hi - my apologies if this isn't the correct place to post. I've been noticing some crashing issues with the latest version of SSO (latest as of a week ago). Seems to happen any time I crouch while jumping from a sprint. Checked the crash.txt - not an expert but the obvious culprit seems to be SSO, and I can't seem to think of any mod incompatibilities or options that would be causing this aside from that. This happens every time I do it - in case it's relevant I do have most of the Ghost/Enforcer skills related to movement kills and stamina. crash.txt

morerokk commented 3 years ago

I haven't updated the SSO compatibility yet so there's probably lots of crashes, I'm working on it.

Olivefromspace commented 3 years ago

Ah, wondered if something like that might be the case. You might want to add a disclaimer to the MWS page, then - definitely wouldn't have filed an issue if there had been one (unless I'm completely blind and missed it somehow lol).

morerokk commented 3 years ago

I'll add a disclaimer once I push the update later today, thanks.

Though I'm not sure if this is fixable, SSO seems to completely overwrite some functions (rather than PostHooking them), which is bound to give issues.

Olivefromspace commented 3 years ago

If there's anything I can do to help test I'd be happy to help! Otherwise, thank you for the quick responses and dedication. Love this mod a lot.

morerokk commented 3 years ago

SSO compatibility is temporarily put on hold. The mod updates very fast and is hooked using BeardLib, which means I cannot reliably overwrite the mod's changes. Trying to work around this with delayed calls is quickly turning this codebase into a mess, so I should hold off on that for now.