search

morethancodenl / mtc-cityhall

A cityhall script for QBCore or Qbox Framework, within the script we focused on usability and a clean and clear user interface. In our script you have the choice to take certain jobs and/or provide yourself with an identity card and/or driver's license. This is completely adjustable to make your server according to your own wishes.
https://mtc.tebex.io/
GNU General Public License v3.0
81 stars 16 forks source link

Only Buy licenses you have meta data for #2

Closed Flek26 closed 1 year ago

Flek26 commented 1 year ago

Update wording on My Info tab: https://i.imgur.com/6DVVHZF.png

With Meta Data for licenses: https://i.imgur.com/SKaMMsa.png Without Meta Data: https://i.imgur.com/orP5uhO.png

Can now close using escape

NietThijmen commented 1 year ago

Hi @Flek26, i've just had 2 comments, would it be possible to maybe fix/answer them. Thanks in advance.

Flek26 commented 1 year ago

Hi @Flek26, i've just had 2 comments, would it be possible to maybe fix/answer them. Thanks in advance.

Sure what's up @legende11

NietThijmen commented 1 year ago

Hi @Flek26, i've just had 2 comments, would it be possible to maybe fix/answer them. Thanks in advance.

Sure what's up @legende11

In client/nui.lua you at line 58 you hardcoded the items[1] would this have any reason? As that makes it less configurable

And the other one i appear to be stupid, as Player licenses doesnt have a number as key. So i thats fine

Flek26 commented 1 year ago

Hi @Flek26, i've just had 2 comments, would it be possible to maybe fix/answer them. Thanks in advance.

Sure what's up @legende11

In client/nui.lua you at line 58 you hardcoded the items[1] would this have any reason? As that makes it less configurable

And the other one i appear to be stupid, as Player licenses doesnt have a number as key. So i thats fine

The reason for that is ID_Card does not contain a Meta option for it. So this way ID_Card is always allowed to be purchased. If you don't want them able to purchase id_card - remove the hard code option and remove it from the config.

NietThijmen commented 1 year ago

LGTM