morethanmin / morethan-log

😎 A static blog using notion database
https://morethan-log.vercel.app
MIT License
1.95k stars 1.57k forks source link

FIX :: utterances config to use record #316

Closed guesung closed 10 months ago

guesung commented 10 months ago

Description

What I Did

I refactored the existing codebase, replacing the { [key: string]: string } type notation with the more concise and TypeScript-specific Record<string, string> type. This change is aimed at enhancing code readability and leveraging TypeScript's advanced type capabilities for better type checking and maintainability.

Proposal

I propose that this refactor be merged into our main codebase. The use of Record<string, string> not only simplifies our type definitions but also aligns with best practices in TypeScript for handling homogenous types. This change will make our code more robust and easier to understand, especially for new developers joining the project. Additionally, this modification paves the way for further improvements in our type system and overall code quality.

Related tickets

https://github.com/morethanmin/morethan-log/issues/XX

PR Checklist

vercel[bot] commented 10 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @morethanmin on Vercel.

@morethanmin first needs to authorize it.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
morethan-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 24, 2023 11:00am