moretrim / ccHFM

Community Curated HFM
14 stars 3 forks source link

Improper return of Persian Kurdish cores to Persia after Bedr Khan rebellion #103

Closed rogerburks closed 3 years ago

rogerburks commented 3 years ago

As the Ottoman Empire, it makes intuitive sense to take concessions such as Tabriz from Persia as soon as possible, before the United Kingdom or Russia can interfere. However, this is strategy is foiled, in a probably unintended way, after the Bedr Khan rebellion, which sees the Ottoman Kurdish satellites form Bohtan and release.

Event 986503 usually sees the Ottoman Empire declare war to annex Bohtan. This sets the flag return_persian_lands_on_finish, which is used by event 986505 to "Event to return persian lands that were conquered during the Bedr Khan rebellion and clean cores" as the comment states. However, if you have taken any other Persian cores before the rebellion, it returns those to Persia too:

https://github.com/moretrim/ccHFM/blob/e9e6e9bad7e585acd1b082da13b73e0374f1d6e5/ccHFM/events/Ottoman%20Empire.txt#L2247

Yet, the code does not seem to be working as intended. Take for instance Bohtan upon rebellion, which does not include any part of Tabriz, nor any province that is normally part of Persia:

image

Strangely enough, Persia's war against Bohtan has war goals to Acquire Tabriz, and Acquire Luristan, but Bohtan has no province from either of these states:

image

This suggests that the event chain is incomplete, and that Bohtan is meant to annex the Persian Kurdistan satellites when the event expands Bohtan. Additional evidence of this is indicated by the code in event 986503, which attempts to annex Kurdish any_country to Bohtan. It includes the Persian satellites Mukriyan (MKN) and Ardalan (RDL). However, these tags, when played by the a.i., are invariably annexed to Persia by this time and their cores are replaced by Kurdistan cores.

https://github.com/moretrim/ccHFM/blob/e9e6e9bad7e585acd1b082da13b73e0374f1d6e5/ccHFM/events/Ottoman%20Empire.txt#L1969-L1984

This suggests that the early annexation of a.i. Mukriyan and Ardalan in revoke_kurdish_autonomy may fire prematurely. Ardalan is reported to have ended in 1865 at the earliest. Mukriyan officially ended circa 1800, but held local control of its area until World War I.

It is realistic to believe that Bedr Khan should have control of the Persian Kurdish cores, given mention that he extended his control to Mahabad. Nevertheless, it makes little sense to return these provinces to Persia if one has already spent infamy acquiring them.

This problem scenario works like this:

before event 986505: image

after event 986505: image

One solution to this scenario would be to delay revoke_kurdish_autonomy until after the Bohtan has been annexed. An alternative would be to reinstate Ardalan and Mukriyan after Bohtan is annexed, enabling revoke_kurdish_autonomy in 1865. This would have an effect on the player strategy of demanding a Tabriz concession, making it especially more difficult to achieve from the Ottoman border, but this is potentially countered by the appeal of greater historical accuracy.