moretrim / ccHFM

Community Curated HFM
14 stars 3 forks source link

Aden seizing and Aden Protectorate formation modified #110

Closed rogerburks closed 3 years ago

rogerburks commented 3 years ago

References issues #59 and #36. Particularly, #59 lists historical references and discusses tuning decisions and localisation characterization for the added flavor.

The regular HFM seizing of Aden and formation of the Aden Protectorate are commented out to make the following changes, because they shared only a little with the new edits. Rather than changing the existing decisions, which would render them less recognizable in the files, I decided to make new files and add new decisions.

The problems addressed were originally noticed because of the lack of player protection for the owner of Aden, as detailed in #36. In discussion of this, historical clarification was provided by arkhometha, who also expressed a wish for the Aden Protectorate to be formed by diplomacy instead of the repeated ahistorical wars to establish protectorates, that happen in both HPM and HFM. This led to some additional research and work on my part to bring that about as a more elegant solution to the problem.

Historical flavor is added to portray the events leading to formation of the Aden Protectorate, with some minimum flavor included. It starts with flavor that can lead to the historical occupation of Aden by the United Kingdom. From there it describes the periodic Fadhli raids on Aden, and covers the 1866 British military retribution against Fadhli. An event is added that describes that Kathiri-Qu'aiti conflict that was recorded starting in 1858. For Mahra, the possibility of a Socotra purchase is added, by a Great Power owner of Bombay from certain continents, expected to be the United Kingdom. From there, if conditions are right, the Aden Protectorate will be formed. Informal protection is offered for Kathiri and Mahra before the Aden Protectorate is formed, occurring on historical timing. Player protection exists for most of these stages, but excessively slow westernizers can lose by 1888. A decision is added for a late-released Kathiri or Mahra to petition to join Yemen if conditions are right. Added a brigade to Fadhli to properly back up its belligerence, and especially to explain why Lahej would ask for help from the UK to fight Fadhli. Also I added a historical land military leader for Fadhli: Ahmad ibn `Abd Allah al-Fadli. New graphics are added for events and decisions. National Unification of Yemen no longer removes cores, because some internal instability is desired in Yemen.

Changes to tag tuning now render Fadhli stronger, and Kathiri more challenging to play. This means that Yemen should be fairly easy for the player to form as Lahej, Fahdli, or Mahra, but difficult for Kathiri. Formation may be easiest as Fadhli, but Mahra also has an especial advantage. Bad luck can hurt a Lahej campaign against Fadhli, but otherwise Lahej should have no serious difficulty forming Yemen.

Various notable bugfixes to the above: Added an event for Fadhli Punishment, because it seemed inappropriate for the war start without explanation. Also, allowed it to occur even when Fadhli is in the sphere of the owner of Aden, because this seems allowable in historical terms. Some localisation was adjusted and added to make the text more flavorful.

Fixed an issue with tags not being offered informal protection if they were already in the great power's sphere.

Replaced modifiers for the Aden raids, since they appear to have no effect as event modifiers, according to the wiki. I replaced them with import_cost which hopefully has an effect.

Discovered that Mahra can refuse the Socotra Purchase while in the sphere of the country requesting it. This led me on a merry chase where I realized that in_sphere = FROM would not work, at least in this case, to specify ai_chance modifier factors. It instead led the Mahra ai to settle on one option out of three 100% of the time, even when its factor is 0. Eventually, I fixed the issue, and I have blamed it on a delay of 3 days being built in between the decision and the events that it spawns. This seemed to make the game confused over the tag that FROM references. I changed the delay to 0 days, and now I have my factors as I wanted them.

Added quotes to event localisation markers.

Fixed a bug with ai decision modifiers for tags that could petition to join Yemen, which had prevented the decision after it from working. Also removed the ai modifier factor that affected ai choice when Yemen had at least one brigade, because it did not work and was covered by another modifier.

Made the Kathiri-Qu'aiti conflict also happen to puppeted Yemen, as was historical. Required Fadhli to have a brigade to raid Aden.

Made a minor change to localisation to inform the player of why the conflict happens to puppeted Yemen.