References #70 and #73. In many cases, the cores of tags that start uncivilized are removed by decisions and events that are meant to simulate historical change from uncivilized areas to colonies to post-colonial areas. However, if cores are considered to be claims, this should arguably not occur under many conditions while the tag still exists. Gameplay of a large number of tags is affected, including most tags from Africa, Malaysia, and Indonesia. Rupert's Land, Louisiana, and Acadia are civilized tags that are also affected.
The core removal method that I chose is a little longer than the usual method, but it has worked in all tests to remove cores only and precisely when and how I wanted:
An exception where core removal seems justified, is when tags give up cores in treaties and through other agreements. Under those circumstances, this fix is not applied. Additionally, I have allowed core removal in cases where the tag no longer exists, such that simulated historical change occurs as intended. I have ignored removal of ENG cores in the New World, since those should happen always through ENG giving up cores voluntarily. In other cases, especially within Europe, it seemed like a bad idea to change anything.
In the course of making changes, I removed cleanup_colonial_cores, since that decision should not exist if core removal functions as intended.
I changed organize_ghana and reorganize_ghana to require a tag to own the in-game capital of Ashanti, since core removals were not working while Ashanti and other tags with claims on Ghana existed. This seemed justifiable to me since otherwise only a single coastal province was required to organize all of Ghana.
I removed a few apparently arbitrary Malay core changes in 97122, Anglo-Siamese Treaty of 1909, because it did not make sense to switch around and not remove the claims of tags that do not exist. I additionally made some changes to add Malaysia cores properly to its provinces.
The initial set of changes succeeded with only a few noticed bugs. These and matters requiring investigation are listed and discussed in this post.
References #70 and #73. In many cases, the cores of tags that start uncivilized are removed by decisions and events that are meant to simulate historical change from uncivilized areas to colonies to post-colonial areas. However, if cores are considered to be claims, this should arguably not occur under many conditions while the tag still exists. Gameplay of a large number of tags is affected, including most tags from Africa, Malaysia, and Indonesia. Rupert's Land, Louisiana, and Acadia are civilized tags that are also affected.
The core removal method that I chose is a little longer than the usual method, but it has worked in all tests to remove cores only and precisely when and how I wanted:
https://github.com/moretrim/ccHFM/blob/dc9c8360ea4122253fee838cf485e70b282915fd/ccHFM/decisions/New%20Colonies.txt#L5510-L5521
An exception where core removal seems justified, is when tags give up cores in treaties and through other agreements. Under those circumstances, this fix is not applied. Additionally, I have allowed core removal in cases where the tag no longer exists, such that simulated historical change occurs as intended. I have ignored removal of ENG cores in the New World, since those should happen always through ENG giving up cores voluntarily. In other cases, especially within Europe, it seemed like a bad idea to change anything.
In the course of making changes, I removed
cleanup_colonial_cores, since that decision should not exist if core removal functions as intended.I changed
organize_ghanaandreorganize_ghanato require a tag to own the in-game capital of Ashanti, since core removals were not working while Ashanti and other tags with claims on Ghana existed. This seemed justifiable to me since otherwise only a single coastal province was required to organize all of Ghana.I removed a few apparently arbitrary Malay core changes in
97122,Anglo-Siamese Treaty of 1909, because it did not make sense to switch around and not remove the claims of tags that do not exist. I additionally made some changes to add Malaysia cores properly to its provinces.The initial set of changes succeeded with only a few noticed bugs. These and matters requiring investigation are listed and discussed in this post.