moretrim / ccHFM

Community Curated HFM
14 stars 3 forks source link

British Dominion release events are retuned to be less spammy #142

Open rogerburks opened 2 years ago

rogerburks commented 2 years ago

References #96

The decrease in dominion-release related event spam is accomplished through the addition of a blank country modifier that enforces a 1000-day cooldown. This cooldown agrees approximately with the time between historical British Colonial Conferences. If a dominion is released, the cooldown is not incurred. If release is refused, the cooldown is incurred.

This change was done because of the excessive amount of times that dominion release events repeat when Newfoundland is owned, most notoriously, but also for other held territories as well that are meant to be eventually released as British dominions. Additionally, the pressure to release dominions seemed to be misinterpreted by the code, which suggested that rebellions would otherwise soon occur. Instead, these events were more orderly historically, with real pressures but not incipient rebellion at the time of release.

Some of these events, especially Canadian, are retuned to take into account historical factors leading to the concept of British Dominions. Some militancy and consciousness effects of release refusal are toned down to be more realistic given the relatively orderly establishment of British dominions historically. Others are less modified, because I believe that once Canada had become a dominion, it made further dominions much more likely.

In the course of addressing the cited issue, I noticed that event 999100 "#Imperial Conference 1907" exists already. This suggests to me that, despite the titles, most dominion release events are meant to simulate cases where colonies were given self-rule due to the concept of responsible government. The switch to dominions occurs in 999100 for most.