Open rogerburks opened 2 years ago
I did not find any additional hidden infamy, but I did find some other minor problems. It seemed best to address them all at once:
louisiana_rename
could never have its allow satisfied by its effect once it became allowed. This was because renamed_washington
flags should have been renamed_montana
flags. This suggests that the other states were meant to be renamed as well, especially because Washington state and provinces are not renamed.
Louisiana is misspelled a few times in localisation.
event 95650
, "French Indochina," is a repeating event intended to award a casus belli to France for the gradual formation of French Indochina. The event would continue to fire, but would not award a casus belli, only when provinces held by SIA
fit the trigger. The cause seems to be that demand_concession_BC_casus_belli
is invalid for this purpose. Switching it to demand_concession_casus_belli
fixes the problem. However, balancing issues remain. This is because the event could be used to demand concessions from Thailand until it is left with only its capital state. This seemed like an idea for a separate issue, since it is a balancing issue and not a bug fix.
In event
99949
"The Death of Henri Riviere" leads directly to99955
, which costs France fullestablish_protectorate_casus_belli
infamy (20 infamy). Because it is a chain of events, each with only one option, the player has no warning or choice about this infamy cost:https://github.com/moretrim/ccHFM/blob/47becfb5ccb5c1e4786bb500f718b524df991b20/ccHFM/events/FlavourMod_FRA.txt#L90-L97
The solution to this and other such problems is to grant a casus belli before using
war
. This results in a lack of infamy cost.I have decided to go over the code in an attempt to find all other events that incur this unavoidable infamy cost. One known case is addressed separately in #137. I will go through a French playthrough to find out if any additional hidden infamy occurs.