Heavenly Kingdom is not Mahayana

[rogerburks]

The Middle Kingdom event (90900) in China.txt westernizes Heavenly Kingdom in the same way that the Qing Empire would be westernized, including changing the nation's religion to Mahayana for no apparent reason. I have created separate paths for Heavenly Kingdom and Qing Empire westernization, however there could be lingering problems that may need to be addressed.

[moretrim]

A quick overview of the situation. The Westernisation events are set by:

https://github.com/moretrim/PFH/blob/bc42da48dbfbc09d2257055a9c8a839b33a111e7/PFH/common/on_actions.txt#L126-L131

These are:

• 90910 in general
• 90900 for the big Chinas (QNG, CHI, or TPG)
• 90903 for the Chinese minors/substates (if they beat the big Chinas to the punch)

Out of all of these, only 90900 changes state religion. This only takes place in HFM, upstream does not have it.

Given the circumstances, I'm inclined to just chuck the religion switch away—if there's a good reason HFM has it, it simply doesn't say why. We can revert this removal if it turns out it's somehow harmful.

[rogerburks]

This makes sense to me, and is easier than my splitting things up. This is the passage where things go a bit awry, which seems to be associated possibly with the missionary_activity flag. I really do not know exactly what those flags do without looking them up, and so I'll want to do that before calling this one finished.

https://github.com/moretrim/PFH/blob/699f8f240acf584dad64c2e6a9316ade0f649563/PFH/events/China.txt#L30-L35

Exploring this: modifier: missionary_activity "Foreign missionaries are active in our country" , also with a flag of the same name to keep it going possibly. It comes into play in a few places for uncivs.

• conversion_chance The modifier affects conversion chance mean time to happen in pop_types.txt:

https://github.com/moretrim/PFH/blob/bc42da48dbfbc09d2257055a9c8a839b33a111e7/PFH/common/pop_types.txt#L1703-L1739

For Chinese tags, it also occurs in a few places. I think (I hope) that it does not affect Heavenly Kingdom in them, but mentioning them here just in case.

• treaty_of_tientsin This becomes set in the Treaty of Tientsin decision (Second Opium War treaty) in FlavourMod_Qing.txt:

https://github.com/moretrim/PFH/blob/bc42da48dbfbc09d2257055a9c8a839b33a111e7/PFH/decisions/FlavourMod_Qing.txt#L186-L201

• 99010 These same changes, including the religion command, happen in the "Boxers attack Legation Quarter" event in BoxerRebellion.txt:

https://github.com/moretrim/PFH/blob/bc42da48dbfbc09d2257055a9c8a839b33a111e7/PFH/events/BoxerRebellion.txt#L422-L429

• imperial_decree_of_war This happens again in the Imperial Decree of War decision:

https://github.com/moretrim/PFH/blob/bc42da48dbfbc09d2257055a9c8a839b33a111e7/PFH/decisions/FlavourMod_Qing.txt#L423-L431

[rogerburks]

For protestant_country , this seems to be one of several flags that govern colony organization, and so I think it is highly advisable to keep it for Heavenly Kingdom. For instance:

• organize_togo

https://github.com/moretrim/PFH/blob/bc42da48dbfbc09d2257055a9c8a839b33a111e7/PFH/decisions/New%20Colonies.txt#L347-L350

change_to_protestant seems to only affect a flag that is given to an unciv in the "$FROMCOUNTRY_ADJ$ Missionaries" event, again best to be retained but mostly harmless for Heavenly Kingdom:

• 90962

https://github.com/moretrim/PFH/blob/bc42da48dbfbc09d2257055a9c8a839b33a111e7/PFH/events/CivilizationAndGunBoats.txt#L5138-L5146

missionary_activity looks like something that should be cleared upon any westernization, and is a modifier affecting various things, including militancy, conversion chance, and research points.

[rogerburks]

Here I remembered that I said I was going to update this and forgot to do it. I am uploading an update now, and will playtest it to see if the removal of religion specification upon westernization does anything.

[rogerburks]

To summarize with the new fixes, you can tell what the state religion is (as long as there are no other effects that convert pops), because other pops will have a conversion factor. Here immediately before westernization, Heavenly Kingdom is protestant:

After westernization, the conversion is still working:

[rogerburks]

For the Qing Empire given these changes, before westernization, pops are converted to Mahayana:

After westernization this is still true:

Therefore, the changes seem to have no ill effect.