moretrim / ccHFM

Community Curated HFM
14 stars 3 forks source link

Non-existing cultural unions cannot be liberated #74

Open moretrim opened 4 years ago

moretrim commented 4 years ago

In a save game involving the German liberation of Russian-held, Poland I have narrowed the culprit down to this kind of condition:

https://github.com/moretrim/PFH/blob/286ab7c7f9f097375ea9ff74a0def71d2db2ef73/PFH/common/cb_types.txt#L2248-L2254

Since Poland is a cultural union, and is not on the map, it’s entirely up to the involved_in_crisis = yes condition to keep Poland as a valid liberation target. As previously discussed before off Github however the crisis conditions (e.g. crisis_exist, involved_in_crisis, is_liberation_crisis, etc.) are only meaningful during a crisis. Even if the crisis is not peacefully resolved, they stop being useful the day the follow-up war breaks out.

My understanding is that this is usually resolved through careful use of war_with = THIS. However since involved_in_crisis appears in a bunch of other conditions as well and since this should also affect upstream I intend to kick the can up for advice first.