morevnaproject-org / papagayo-ng

Papagayo is a lip-syncing program designed to help you line up phonemes (mouth shapes) with the actual recorded sound of actors speaking. Papagayo makes it easy to lip sync animated characters by making the process very simple - just type in the words being spoken (or copy/paste them from the animation's script), then drag the words on top of the sound's waveform until they line up with the proper sounds.
233 stars 51 forks source link

Feature request - volume control #20

Closed tjoen closed 6 years ago

tjoen commented 8 years ago

It might be in the program somewhere, but I can't seem to adjust the volume of the wav?

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/37682563-feature-request-volume-control?utm_campaign=plugin&utm_content=tracker%2F418652&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F418652&utm_medium=issues&utm_source=github).
morevnaproject commented 7 years ago

There is no volume control available within Papagayo-NG yet.

steveway commented 7 years ago

I've got a very stupid implementation working in my testing branch: https://github.com/steveway/papagayo-ng/commit/f562dc0628277a2c16dc9d368477c52faac3eaa4 There is no GUI to change the volume, you need to change the self.volume value from 0 to 100. I will most likely discard this idea. The better solution would be to change the volume of the samples in SoundPlayer.py in the _play method directly. I'm also using NamedTemporaryFile there, which is a better solution than the current fake temp file we use.

steveway commented 7 years ago

Alright, I created a quite well working version to a branch of mine here: https://github.com/steveway/papagayo-ng/tree/working_vol There is still no GUI to change the volume. I'll do a few tests of this and when my other Pull request is done I'll create a Pull request for this before tackling the GUI part of this.

steveway commented 7 years ago

Pull-Request #24 should now fix this.

tjoen commented 6 years ago

Newest release has this feature, So closing it.