search

morevnaproject-org / papagayo-ng

Papagayo is a lip-syncing program designed to help you line up phonemes (mouth shapes) with the actual recorded sound of actors speaking. Papagayo makes it easy to lip sync animated characters by making the process very simple - just type in the words being spoken (or copy/paste them from the animation's script), then drag the words on top of the sound's waveform until they line up with the proper sounds.
233 stars 51 forks source link

REFACTORING for wxPhoenix v.4+ and DEPRECIATING wxGlade #48

Closed egoZentric closed 5 years ago

egoZentric commented 6 years ago

Hej Guys.

I forked PPG-NG 1.4 . I bring wxPython expertise to the table. BUT this code base is really a big spageti mess. allow me to clean up and make it ready for further development,

As of now - this pull req - it runs on python 3.7 on a windows x64

\eZ

steveway commented 6 years ago

Hey, that is cool! This project can use some clean-up. It's great having people helping any tiny bit. I had a quick look over the commits and it seems to look quite good. So, if Konstantin likes this this will likely get merged. Uhm, but there is a small but. Most of the development is at the moment happening on the QT Port. The development is pretty far advanced already. But there is still a bit that needs to be done before the transition is complete. So fixes and improvements to the wx version are still useful. Just so you know when investing bigger chunks of time.

morevnaproject commented 6 years ago

Hello! I have made a quick look at all changes and tested with Python2 / WxGtk3. Looks good!

I also like changes in Readme.txt file. @steveway I think it worth to copy contents of Readme to your QT Port branch.

Regarding future development of Papagayo-NG - yes, we are moving from wxWidgets to python-QT. It is very close to usable status and the future development is relevant there. Please check this therad - https://github.com/morevnaproject/papagayo-ng/issues/33 Any help with QT port is much appreciated. Thank you!

morevnaproject commented 6 years ago

I think we should keep "import gettext" and related _() function - https://github.com/morevnaproject/papagayo-ng/pull/48/files#diff-5ef6458f48b15dc67b7eff21401b3e13L23

_()function is not related to wxGlade. It is a functionality provided by gettext. The localization should be provided according to instructions here - https://docs.python.org/3/library/gettext.html?highlight=gettext#localizing-your-application

morevnaproject commented 5 years ago

@egoZentric So, can you please revert commits 0109d2f9b3f and d65870f9ac1e6a, so I can merge your changes? We would like to keep gettext, as explained above.

morevnaproject commented 5 years ago

Closed because of inactivity.