Closed rhin0cer0s closed 10 years ago
My answer to (1) is quite trivial, but I will try it anyway: it depends on the level of coupling between the existing branch and your future modifications:
master
,Now that we have the foundations, we should be able to make incremental, well defined changes that impact only a small fraction of the code base.
In these cases I can accept pull request several times a day, so you should be able to always branch from master
.
If your PR is ready and I have not accepted it yet, you could do some incremental work on the report in the mean time :-)
About (2), I would advise you to open as many issues as needed so that each issue can be fixed by one "independent" PR. You can reference related issues ("#" followed by the number of the issue) when it is handful. Focused issues are easier to discuss and track, focused PR are easier to merge :-)
@rhin0cer0s @zorgulle : every time you think a PR is ready for merge, please signal it in a comment on the PR.
@rhin0cer0s : this is a good use of labels, however I would prefer "NonLexicalized" rather than "Fake", to adhere to the Wordnet terminology (see #17 ).
Ok I think it is good for this one, we have labels on nodes.
I made this branch for the node labels issue.
I'll take this opportunity to ask some questions :