search

morfologik / morfologik-stemming

Tools for finite state automata construction and dictionary-based morphological dictionaries. Includes Polish stemming dictionary.
BSD 3-Clause "New" or "Revised" License
187 stars 44 forks source link

improve run-on suggestions for camel case words #114

Closed jaumeortola closed 2 years ago

dweiss commented 2 years ago

This will generate some (a lot?) false-positives. Like "aloft" could be "a loft" but can also be "aloft".

dweiss commented 2 years ago

I've reverted this, temporarily. See @milekpl 's comment

jaumeortola commented 2 years ago

I can see a comment by @milekpl on my mail, but not online. What is the problem?

dweiss commented 2 years ago

I've no idea - I have the same thing!

milekpl commented 2 years ago

Oh, I did remove my comment because it was false! :) I added the junit test cases. I wrote my comments before running the test cases and saw that they worked, so I deleted it immediately. Sorry!

dweiss commented 2 years ago

Should I merge it in then?

milekpl commented 2 years ago

Sure. Please merge. Note that test cases will fail without the merge as well.

dweiss commented 2 years ago

Done! I'll try to prepare a release over the next few days.