search

morfologik / morfologik-stemming

Tools for finite state automata construction and dictionary-based morphological dictionaries. Includes Polish stemming dictionary.
BSD 3-Clause "New" or "Revised" License
187 stars 44 forks source link

strange definition of CamelCase #28

Closed danielnaber closed 6 years ago

danielnaber commented 10 years ago

Speller.isCamelCase() considers words like Waschmaschinen-Test to be camel case. If that's on purpose, it should be documented. For German, these are common words and I wouldn't consider them camel case.

milekpl commented 10 years ago

No, it's a side effect. Will think how to fix it.

dweiss commented 9 years ago

Is this still valid?

danielnaber commented 8 years ago

The issue is still valid in 1.10 and I don't see any change in the source that addresses it in 2.0. But adding a sentence to the javadoc seems a good enough fix, like Note that German compounds with a dash (like "Waschmaschinen-Test") are also considered camel case by this method.

dweiss commented 8 years ago

Can you provide a pull request for this, Daniel? I'll merge it in.

danielnaber commented 6 years ago

Closing, has been fixed (well, documented) long ago.