morfologik / morfologik-stemming

Tools for finite state automata construction and dictionary-based morphological dictionaries. Includes Polish stemming dictionary.
BSD 3-Clause "New" or "Revised" License
187 stars 44 forks source link

FSADump: -x not optional #35

Closed danielnaber closed 9 years ago

danielnaber commented 9 years ago

The help output of FSADumpTool describes -x as optional, at least that's what I understand by "if available":

Decode prefix/ infix/ suffix forms (if available).

But when I run java -jar morfologik-tools-1.9.0.jar fsa_dump -x -d pl_PL.dict (the Polish dict from LT), I get this error:

java.lang.RuntimeException: Invalid dictionary entry format (missing separator).
 at morfologik.stemming.DictionaryIterator.next(Unknown Source)
 at morfologik.stemming.DictionaryIterator.next(Unknown Source)
 at morfologik.tools.FSADumpTool.dump(Unknown Source)
 at morfologik.tools.FSADumpTool.go(Unknown Source)
 at morfologik.tools.Tool.go(Unknown Source)
 at morfologik.tools.FSADumpTool.main(Unknown Source)
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:606)
 at morfologik.tools.Launcher$ToolInfo.invoke(Unknown Source)
 at morfologik.tools.Launcher.main(Unknown Source)

Without -x, it works. Maybe -x should be optional, i.e. it there's nothing to decode, this option should be ignored.

danielnaber commented 9 years ago

Oh, I now see issue #15 is about this. So maybe just the help text should be rephrased.

dweiss commented 9 years ago

Rephrase it! :)