search

morfologik / morfologik-stemming

Tools for finite state automata construction and dictionary-based morphological dictionaries. Includes Polish stemming dictionary.
BSD 3-Clause "New" or "Revised" License
186 stars 44 forks source link

Add DependencyConvergence checks to parent pom #78

Closed aldenquimby closed 8 years ago

aldenquimby commented 8 years ago

This fixes a dependency convergence issue introduced via https://github.com/morfologik/morfologik-stemming/commit/3ada8d8b47ca8495de3415d5e76dbf99fa971760.

Any projects that currently depend on morfologik 2.1.0 and have maven-enforcer dependency convergence enabled need to add a morfologik-stemming entry in dependencyManagement to deal with the conflict.

I came across this when upgrading my languagetool dependency from 3.1 to 3.3 - see https://github.com/languagetool-org/languagetool/pull/342#issuecomment-205774094 for additional context.

I added a dependency convergence check to the morfologik parent so that I could test this change by running mvn validate. I'm happy to remove that, or move it, if you don't want to enforce dependency convergence.

dweiss commented 8 years ago

Thanks for pointing this out -- this is in fact a bug, the whole dependency is a mistake (don't know why it ended up there).

dweiss commented 8 years ago

Could you rebase your patch on top of the removed dependency section (just add dependency convergence checks). Also, this plugin should run only in verify phase, no need to do it all the time.

aldenquimby commented 8 years ago

@dweiss thanks for the quick response here. I rebased and moved to verify phase - anything else I should do for this?

dweiss commented 8 years ago

Nope, this looks good -- thanks!