search

morfologik / morfologik-stemming

Tools for finite state automata construction and dictionary-based morphological dictionaries. Includes Polish stemming dictionary.
BSD 3-Clause "New" or "Revised" License
186 stars 44 forks source link

Misleading DictionaryMetadataBuilder option name #82

Closed mkopec87 closed 7 years ago

mkopec87 commented 7 years ago

Hi,

I find DictionaryMetadataBuilder frequencyIncluded() option misleading, one may expect that it would mean that frequency WILL be included, but in fact it is not.

All best, Mateusz

dweiss commented 7 years ago

This looks like a bug to me indeed. Care to provide a pull request?

mkopec87 commented 7 years ago

I did. This is my first pull request on GitHub ever, so please tell me if I did anything wrong :)

dweiss commented 7 years ago

Fixed in PR #83.

bq. This is my first pull request on GitHub ever,

Well, congratulations -- you're off for a good start!