search

morganey-lang / Morganey

Lambda Calculus based, interpreted programming language that recognizes Church encoded structures.
43 stars 4 forks source link

[WIP] Better quotations #349

Open keddelzz opened 7 years ago

keddelzz commented 7 years ago

see #345

ForNeVeR commented 7 years ago

QuotationMacro.scala is the bigest source code file in the entire codebase

I agree.

That's due to new big methods that contain many nested functions. Probably we should somehow extract their contents to a new module with well-defined semantic.

keddelzz commented 7 years ago

Thank you guys for your review!

QuotationMacro.scala is the bigest source code file in the entire codebase. Please decompose it accordingly.

I'll look into that!

I think that it demands some additional tests.

There are a few tests for the previous, non-generic sequence implementation, the change didn't break those. Nevertheless I agree! I'll add more tests.

Unfortunately, I'm very busy at the moment, so I'll look into it, when I have some time to spare. Apologies in advance for the inconvenience of leaving this PR untouched for a while.

rexim commented 7 years ago

@keddelzz yeah, I understand. I'm busy too. :) That's why I answer with such a delay. Don't worry, take your time.