search

morgangraphics / ansible-role-nvm

Installs NVM & Node.js on Debian/Ubuntu and RHEL/CentOS
MIT License
102 stars 29 forks source link

Fixes installations in shells other than bash #50

Closed samuelpismel closed 4 months ago

samuelpismel commented 4 months ago

The NVM install script requires bash to run successfully. If you try to use another shell like zsh, you will get this error message:

wget -qO- https://raw.githubusercontent.com/creationix/nvm/v0.39.7/install.sh | zsh
Error: the install instructions explicitly say to pipe the install script to `bash`; please follow them

This pull request fulfills this requirement.

morgangraphics commented 4 months ago

First, thank you for taking the time to submit a pull request. I appreciate the effort. However, your pull request isn't up to snuff with how the role works. You essentially blow away all the other shell options by forcing everything to use bash.

I have been working on a new version of the role which handles pipefail as well as other various improvements here https://github.com/morgangraphics/ansible-role-nvm/pull/49/files. My version handles pipefail for shells that support it and ignores it for those that don't. It is currently in testing and should be ready for release shortly.