morganstanley / ComposeUI

A .NET Core based, WebView2 using UI Container for hybrid web-desktop applications
https://morganstanley.github.io/ComposeUI/
Apache License 2.0
64 stars 23 forks source link

POC/adaptive cards #814

Closed Sanjuice closed 2 weeks ago

Sanjuice commented 1 month ago

This is a proof of concept for adaptive cards using javascript.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 1.98675% with 148 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (502fb1d) to head (8211d10). Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/shell/dotnet/Shell/Layout/LayoutManager.cs 0.00% 118 Missing :warning:
src/shell/dotnet/Shell/MainWindow.xaml.cs 0.00% 18 Missing :warning:
.../shell/dotnet/Shell/Layout/MainWindowParameters.cs 0.00% 5 Missing :warning:
src/shell/dotnet/Shell/MainWindow.xaml 0.00% 3 Missing :warning:
src/shell/dotnet/Shell/WebContentPane.cs 0.00% 3 Missing :warning:
src/shell/dotnet/Shell/App.xaml.cs 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814/graphs/tree.svg?width=650&height=150&src=pr&token=hFA8aXtE09&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley)](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley) ```diff @@ Coverage Diff @@ ## main #814 +/- ## ========================================== - Coverage 68.85% 67.67% -1.18% ========================================== Files 300 300 Lines 8871 8982 +111 Branches 921 1032 +111 ========================================== - Hits 6108 6079 -29 - Misses 2543 2686 +143 + Partials 220 217 -3 ``` | [Files with missing lines](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley) | Coverage Δ | | |---|---|---| | [...mposeUI.LayoutPersistence/FileLayoutPersistence.cs](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814?src=pr&el=tree&filepath=src%2Flayout-persistence%2Fdotnet%2Fsrc%2FMorganStanley.ComposeUI.LayoutPersistence%2FFileLayoutPersistence.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley#diff-c3JjL2xheW91dC1wZXJzaXN0ZW5jZS9kb3RuZXQvc3JjL01vcmdhblN0YW5sZXkuQ29tcG9zZVVJLkxheW91dFBlcnNpc3RlbmNlL0ZpbGVMYXlvdXRQZXJzaXN0ZW5jZS5jcw==) | `92.85% <100.00%> (-0.70%)` | :arrow_down: | | [src/shell/dotnet/Shell/App.xaml.cs](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814?src=pr&el=tree&filepath=src%2Fshell%2Fdotnet%2FShell%2FApp.xaml.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley#diff-c3JjL3NoZWxsL2RvdG5ldC9TaGVsbC9BcHAueGFtbC5jcw==) | `0.00% <0.00%> (ø)` | | | [src/shell/dotnet/Shell/MainWindow.xaml](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814?src=pr&el=tree&filepath=src%2Fshell%2Fdotnet%2FShell%2FMainWindow.xaml&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley#diff-c3JjL3NoZWxsL2RvdG5ldC9TaGVsbC9NYWluV2luZG93LnhhbWw=) | `0.00% <0.00%> (ø)` | | | [src/shell/dotnet/Shell/WebContentPane.cs](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814?src=pr&el=tree&filepath=src%2Fshell%2Fdotnet%2FShell%2FWebContentPane.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley#diff-c3JjL3NoZWxsL2RvdG5ldC9TaGVsbC9XZWJDb250ZW50UGFuZS5jcw==) | `0.00% <0.00%> (ø)` | | | [.../shell/dotnet/Shell/Layout/MainWindowParameters.cs](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814?src=pr&el=tree&filepath=src%2Fshell%2Fdotnet%2FShell%2FLayout%2FMainWindowParameters.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley#diff-c3JjL3NoZWxsL2RvdG5ldC9TaGVsbC9MYXlvdXQvTWFpbldpbmRvd1BhcmFtZXRlcnMuY3M=) | `0.00% <0.00%> (ø)` | | | [src/shell/dotnet/Shell/MainWindow.xaml.cs](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814?src=pr&el=tree&filepath=src%2Fshell%2Fdotnet%2FShell%2FMainWindow.xaml.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley#diff-c3JjL3NoZWxsL2RvdG5ldC9TaGVsbC9NYWluV2luZG93LnhhbWwuY3M=) | `0.00% <0.00%> (ø)` | | | [src/shell/dotnet/Shell/Layout/LayoutManager.cs](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814?src=pr&el=tree&filepath=src%2Fshell%2Fdotnet%2FShell%2FLayout%2FLayoutManager.cs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley#diff-c3JjL3NoZWxsL2RvdG5ldC9TaGVsbC9MYXlvdXQvTGF5b3V0TWFuYWdlci5jcw==) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/morganstanley/ComposeUI/pull/814/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=morganstanley)
lilla28 commented 3 weeks ago

Can you please also squash your commits as well? as they are mostly belongs together (creating adaptive card poc for JS)