morganstanley / hobbes

A language and an embedded JIT compiler
http://hobbes.readthedocs.io/
Apache License 2.0
1.16k stars 105 forks source link

auto fixes from clang tidy for readability and possble(?) performance gain #426

Closed mo-xiaoming closed 2 years ago

smunix commented 2 years ago

possible performance gain

do you have any numbers to share?

Also, we need to add macosx hosts to our github actions workflow. Can you look into this?

mo-xiaoming commented 2 years ago

possible performance gain

do you have any numbers to share?

CPU: AMD Ryzen 7 5700U MEM: 64GB OS: wsl2 ubuntu20.04

run command /usr/bin/time ./hobbes-test 5 times on each branch in the away

  1. main branch
  2. pr branch
  3. main branch
  4. pr branch
  5. ...

Gather the system time (wall time) in seconds

main br pr br
44.60 43.57
44.46 43.17
44.46 43.29
44.20 43.23
44.27 42.98

It is unscientific, but the number is consistent