morganstanley / hobbes

A language and an embedded JIT compiler
http://hobbes.readthedocs.io/
Apache License 2.0
1.16k stars 105 forks source link

array.H: include cstdint to fix llvm 12+ build #452

Closed ghost closed 5 months ago

ghost commented 5 months ago

include cstdint in arrah.H to fix build errors when compiling with llvm-12+.

include/hobbes/util/array.H:325:22: error: unknown type name 'uint8_t'
mo-xiaoming commented 5 months ago

Hi @a-n-n-a-l-e-e , for the moment, hobbes doesn't support llvm12+, at least not officially

ghost commented 5 months ago

Hi @a-n-n-a-l-e-e , for the moment, hobbes doesn't support llvm12+, at least not officially

thats fine -- no harm in adding the header that is responsible for uint8_t tho. https://en.cppreference.com/w/cpp/header/cstdint

feel free to close.

wegank commented 5 months ago

Hi @a-n-n-a-l-e-e , for the moment, hobbes doesn't support llvm12+, at least not officially

In Nixpkgs we do link against LLVM 12. Building the package is another story, and I believe <cstdint> is a missing header for both GCC 13 and Clang 16. So it'll be nice to get this PR in.