search

morganstanley / modern-cpp-kafka

A C++ API for Kafka clients (i.e. KafkaProducer, KafkaConsumer, AdminClient)
Apache License 2.0
331 stars 86 forks source link

Minimum CMake version is too low. #198

Closed vadtec closed 1 year ago

vadtec commented 1 year ago

CMakeLists.txt (main dir, tests/unit/) use cmake_path which is available from CMake 3.20 onward.

cmake_minimum_required(VERSION "3.8")

That should really be updated so that CMake will error out rather than blowing up with errors.

kenneth-jia commented 1 year ago

Good catch! Thank you, @vadtec! Just fixed it with https://github.com/morganstanley/modern-cpp-kafka/pull/199