Fix some OAuth related issues

morganstanley / modern-cpp-kafka

A C++ API for Kafka clients (i.e. KafkaProducer, KafkaConsumer, AdminClient)

Apache License 2.0

331 stars 86 forks source link

Fix some OAuth related issues #233

Closed rockwood-openai closed 4 days ago

rockwood-openai commented 1 month ago

Add logging for config issues
oauth callback expiration should be milliseconds not microseconds
Return on error early during oauth callback
Prevent no config from throwing exception constructing string

rockwood-openai commented 1 month ago

FYI @kenneth-jia

kenneth-jia commented 3 weeks ago

Hi, @rockwood-openai Thank you for your contribute! The fix looks good! The tricky part is I have no privilege to approve the PR (though I'm the author but I'm not a maintainer anymore). Let me discuss with my colleagues and find a way out.😅

rockwood-openai commented 3 weeks ago

Thanks @kenneth-jia and @alex-q-chen

I think CI is broken based on https://github.com/morganstanley/modern-cpp-kafka/pull/232 let me know if there is anything I can do to help.