search

morganthomas / Shpadoinklekasten-lib

Other
0 stars 1 forks source link

View refactor #46

Closed davewripley closed 4 years ago

davewripley commented 4 years ago

Refactor View into pieces

morganthomas commented 4 years ago

Thanks for the contribution, Dave! You followed the right process to submit this by creating your own fork and branch and submitting a PR to origin/master. I validated your changes by checking out your branch and running it through nix-shell, cabal repl, nix-build, and nix-build --arg isJS true. In most cases I would have also run and tested the app, but in this case the changes are so straightforward that the fact that they compile convinces me that the changes are correct. Good job, and I'll merge this now.