search

morganthomas / purescript-group

Algebraic groups for PureScript.
Apache License 2.0
6 stars 6 forks source link

v0.12.0 and psc-package support #14

Closed adkelley closed 6 years ago

adkelley commented 6 years ago

If you like, I'll be happy to add this repository to the psc-package set once my changes have been merged.

morganthomas commented 6 years ago

Thank you for the contribution! I'm unfamiliar with psc-package (I don't do anything with PureScript beyond this package), but I trust that these changes are good.

morganthomas commented 6 years ago

I think it would be good to add this to the package set. Anything needed such as a tag created?

adkelley commented 6 years ago

Glad you agree. No tag necessary. Instructions for adding purescript-group to psc-package can be found here: https://github.com/purescript/psc-package Let me know if would like to do it, or again I'll be happy to add it.

morganthomas commented 6 years ago

Thanks Alex! Please go ahead and add it. :-)

adkelley commented 6 years ago

Hi Morgan. I believe, in order for Bower to pick up the 0.12 changes, that you need to add a new tag (4.0.0). Cheers, Alex

adkelley commented 6 years ago

That did the trick, thank you! I'll submit a pull request to psc-package as well. Check your Travis settings though, it doesn't appear you've had a successful build yet.

Cheers, Alex