search

morhetz / gruvbox

Retro groove color scheme for Vim
13.63k stars 1.11k forks source link

ALE not displaying errors when using gruvbox #266

Open roosemberth opened 5 years ago

roosemberth commented 5 years ago

Pretty much the title, when I switch to use gruvbox ALE warnings are not displayed.

image

Minimal configuration: https://paste.gnugen.ch/raw/4Aww

Steps to reproduce expected: Use the provided configuration as nvim configuration Steps to reproduce actual behaviour: Uncomment lines 14, 17,18 in the provided configuration. This will enable gruvbox in dark mode

Expected behaviour: ALE should highlight errors in file Actual behaviour: No errors are displayed in the file

doums commented 5 years ago

For me, the signs works well but highlights not at all img

If I put something like highlight ALEWarning ctermbg=DarkMagenta in my .vimrc, I get the expected result.

I don't know vim script but I think the problem comes from these lines. Here the guy seems to trying to override the Ale's groups but this does not work for some reasons...

EDIT: as temporary workaround I fixed the issue putting this in my .vimrc

 " fix gruvbox's highlight for Ale
highlight ALEInfo ctermfg=109 cterm=italic
highlight ALEWarning ctermfg=214 cterm=italic
highlight ALEError ctermfg=167 cterm=italic

Unfortunately I have not the vim skill to understand what is going on and to propose a proper fix...

rbong commented 5 years ago

Turns out there is a setting for this problem. Gruvbox uses the underline color for ALE errors/warnings/info. This isn't available in terminal vim, so you have to use let g:gruvbox_guisp_fallback = 'bg' if you want to see the underline color as background color.