search

morhetz / gruvbox

Retro groove color scheme for Vim
13.59k stars 1.1k forks source link

Add ability to customize the color of the vertical split line #355

Closed lucasprag closed 1 year ago

lucasprag commented 3 years ago

Hello, first of, great job on this color scheme, it's my new favorite 🥇

This PR adds the ability to customize the color of the vertical split line.

I know we can customize many colors of this scheme using global variables. We even have a variable to customize the background of the vertical split line, but we can't customize the foreground.

See the screenshots below:

  1. Not customizing the split line at all just for the sake of comparing them (default behaviour for the split line):

pr1 - default

  1. I've customized the vert line using the existing variable let g:gruvbox_vert_split='bg1' so we can see the difference.

pr2

  1. I've customized the new variable g:gruvbox_vert_split_line making the line a bit darker.

pr3

  1. I've customized the new variable to remove the line altogether by matching with the background. (🌟, my favorite)

pr4

This is something that I was using myself and I decided to share because it could be useful for more people. I'll be glad to update the wiki if this PR gets merged.

Thank you 🙌

lucasprag commented 3 years ago

Just following up @morhetz

lucasprag commented 3 years ago

Hey @lukeboyd, I finally did that 👍

ghost commented 3 years ago

@lucasprag. I'm excited to try this. Because Gruvbox is mostly updated by a community fork, you may also want to submit a pull request with your changes there.

I personally use this forked repo with the community repo added as a branch with the respective remote. Makes things a bit easier for developing between the two repos.

I develop on a feature branch off a community-dev branch from a community-master branch which is my fork of the community master. Then merge --no-ff my feature into the community-dev branch and make a pull request to master on the community repo with my community-dev branch since the community master is used as a develop branch.

Only drawback is that submitting pull requests are a bit unconventional being that it is my fork of this repo and not a fork of the community repo.

lucasprag commented 1 year ago

I see, thanks @ellijones . I'm going to close this PR because I'm not using this plugin anymore and don't have a way to test it at this point. Thanks for the help 🙌🏼