moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

import 'zone.js' which may cause duplicate , zone already exist error … #103

Closed richie50 closed 6 years ago

richie50 commented 6 years ago

…fixed and code updates to reflect angular 6.0.3 (current release)

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.007%) to 99.376% when pulling b4c1bc6c421d084609d74267ed83bba035f93c67 on richie50:dev-richie-ng2-idle into 511ee8b6b4fe81dab6204100c622afb4027a9c0f on HackedByChinese:master.

nallarv commented 6 years ago

Looks good. When does this PR get merged?

moribvndvs commented 6 years ago

The most important change is removing the extraneous zone.js import. I'm not sure about your changes for RXJS imports. They don't match the docs from Angular or RXJS. I did go ahead with another change to remove the need for rxjs-compat.