search

moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

Fixed console error on manual localStorage clear #105

Closed amnambiar closed 5 years ago

amnambiar commented 5 years ago

What kind of change does this PR introduce? (check one with "x")

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) When localStorage is cleared manually from Application > LocalStorage > clear button, this will throw console error TypeError: Cannot read property 'indexOf' of null.

What is the new behavior? No console errors will be thrown from now.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ... None

Other information:

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 99.368% when pulling 054e71e865370f68638d145dcc26ffbd3033492a on anu91ab:master into b79ffdee1db474aaf56ee9ef2d39e4ac7b1b5bd4 on HackedByChinese:master.

amnambiar commented 5 years ago

@HackedByChinese could you please merge this one? This would resolve issues in my application.

anusreemn commented 5 years ago

@HackedByChinese Any updates? We are waiting for this to be in. Please merge it in as it is not a harmful code.