moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

Fix keepalive onPingResponse subscribe response doesnt work right #118 #120

Closed mmubasher closed 5 years ago

mmubasher commented 5 years ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) keepalive onPingResponse subscribe response doesnt work right #118

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.001%) to 99.37% when pulling a65451d32da800f8851ff9bb17db7fcb593a591f on mmubasher:master into f3e1e177b6f2f9063639e3be0f0e942bdb70872a on HackedByChinese:master.

mmubasher commented 5 years ago

@HackedByChinese Thank you for accepting the request. Any idea when next release will be and when the latest npm packages will be available? Thank you