moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

Update dev #127

Closed moribvndvs closed 4 years ago

moribvndvs commented 4 years ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe:

Recreates the project using ng-cli, updating a number of out-of-date and vulnerable devDependencies, adding much needed linting and formatting capabilities, and precommit lint+test and commit message linting.

Additionally, recreating with ng-cli brings the project up to date with Angular 8.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.6%) to 100.0% when pulling 45325d3b18e51fdae3d223a78ed177b65c15b919 on update-dev into 0d9980361f46e49b37a9477d6ffbd3df2454252c on master.

moribvndvs commented 4 years ago

That's correct. Interrupt is internal and not meant to be exported.

moribvndvs commented 4 years ago

I'm going to move ahead with merging this and releasing a 8.0.0-beta.1 build.

bfwg commented 4 years ago

LGTM 👍