fix(idle,timeout): countdown idle and timeout based on time

[mychalhackman]

Please check if the PR fulfills these requirements

• [x] The commit message follows our guidelines: https://github.com/HackedByChinese/ng2-idle/blob/master/CONTRIBUTING.md#pr
• [x] Tests for the changes have been added (for bug fixes / features)
• [ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) Timeout and idle do not compensate for time-shifts (e.g.; clock change, device standby).

https://github.com/HackedByChinese/ng2-idle/issues/110 https://github.com/HackedByChinese/ng2-idle/issues/112

What is the new behavior? Idle and timeout are checked every second (instead of once after idle expiry) and compare the system time against the timeout time.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

[coveralls]

Coverage remained the same at 100.0% when pulling db87c4c1fc30d511ed2f9addcf16108b4a78a0b7 on qhrtech:fix-timeout-idle-time-shift into db0148bcb27337deaac5b8828466e39bc0e755cf on HackedByChinese:master.

[kvetis]

This fix is very useful and we've used a "fork" with the almost exact code for years. It would be very helpful to merge this, since we could then upgrade to newer versions. It would also fix #157.

[chinthu]

It would be very helpful if you merge this fix.

[mcrtricolor]

I would also need this fix, thanks.

[gshirley-boku]

I need this fix too, can we have this fix merged anytime soon? 🙇‍♀️

[StefaniToto]

Need this fix as well.

[kemmis]

Please merge. We need this fix too.

[ZoSo1974]

I need it too! Please merge ASAP! :)

[Eldorados]

What is the issue with this PR? 4 years waiting for a much needed fix

Who is able to give the final review and merge?

[reunefe]

@moribvndvs would it be possible to get this one merged? Or does anybody else has write access to could approve this?

[moribvndvs]

Thanks @mychalhackman and all who tested/reviewed it. Sorry it took a lifetime to merge.

[moribvndvs]

Do we need a minor release for the current target of Angular 15 (and do a separate release with it for 16), or just jump straight to 16?

[kemmis]

15 would be nice.

On Wed, Oct 25, 2023 at 12:42 PM Mike Grabski @.***> wrote:

Do we need a minor release for the current target of Angular 15 (and do a separate release with it for 16), or just jump straight to 16?

— Reply to this email directly, view it on GitHub https://github.com/moribvndvs/ng2-idle/pull/131#issuecomment-1779666350, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE6C6KDCBQXQAGZP6KOCV3YBE6Q7AVCNFSM4IVLFNM2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZXHE3DMNRTGUYA . You are receiving this because you commented.Message ID: @.***>

[Eldorados]

I am stuck on 15 for a while longer, so a minor release would be much appreciated on my end!

[reunefe]

I would do separate releases, 1 for the current target of Angular 15 and a separate one for Angular 16. Mainly because Angular 16 has some breaking changes that could impact some things:

• Node upgrade
• Typescript upgrade
• etc

Not sure what the impact would be by using it in, for example my case, angular 14. The current target with angular 15 works fine in an application of Angular 14, but maybe that's just me. Unfortunately I'm still stuck to that version for now

[moribvndvs]

Since it's a fix only, 13.0.1 is the release with this change. It's out on NPM now.