moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

Angular 9 #137

Closed takhil closed 4 years ago

takhil commented 4 years ago

npm WARN @ng-idle/core@8.0.0-beta.4 requires a peer of @angular/common@^8.0.0 but none is installed. You must install peer dependencies yourself. npm WARN @ng-idle/core@8.0.0-beta.4 requires a peer of @angular/core@^8.0.0 but none is installed. You must install peer dependencies yourself. npm WARN @ng-idle/keepalive@8.0.0-beta.4 requires a peer of @angular/common@^8.0.0 but none is installed. You must install peer dependencies yourself. npm WARN @ng-idle/keepalive@8.0.0-beta.4 requires a peer of @angular/core@^8.0.0 but none is installed. You must install peer dependencies yourself.

I'm seeing above warnings when i do "npm update"

Angular version 9.02 node : 12.3 npm : 6.0

Will. there be any issues with these warnings did any one facing issues ?

scottfrenzy commented 4 years ago

I haven't faced any issues yet using angular 9. All seems to be working for me (using idle and keepalive)

sudhakar-sekar commented 4 years ago

Hi,

I am also facing the same issue.

Angular : v9.1.4 NodeJS : 12.16.3 NPM : 6.14.4

When we will expect the Angular 9 support?

Thanks, Sudhakar Chandrasekaran.

iompo commented 4 years ago

Hi guys, I did update the modules core and keep-alive to angular 9.1.6. Who should I ask to be able to propose a pull request?

Marco.

scottfrenzy commented 4 years ago

I did update the modules core and keep-alive to angular 9.1.6. Who should I ask to be able to propose a pull request?

Thanks for doing this! Check out the Submitting a Pull Request section here

moribvndvs commented 4 years ago

Addressed in #141