search

moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
322 stars 129 forks source link

Update to Angular 13's new package format and compile with partial-ivy #165

Closed xylplm closed 1 year ago

xylplm commented 2 years ago

With Angular 13 a new package format was rolled out. They're also encouraging library developers to publish libraries with partial ivy compilation mode, which removes the need for ngcc. This library is not being published with either partial-ivy or the new package format.

`Processing legacy "View Engine" libraries:

If you use ngpackagr and Angular 13 to build the library, then this should be solved naturally. If not, here are the details about the new package format: https://angular.io/guide/angular-package-format

WuglyakBolgoink commented 2 years ago

any update on this issue? now we have angular@14...

HarelM commented 2 years ago

Would be nice to have this warning removed, any info on that? Is there still a maintenance issue (as I've seen a lot of people volunteering to help maintain this package)?

moribvndvs commented 2 years ago

I accept pull requests. I don't have bandwidth for this right now, I hate to say.

As for a help maintaining, I've had people stop by to help but we haven't quite gotten to the point where someone else is proactively maintaining.

HarelM commented 2 years ago

Ok, thanks for the quick response! I'll see what I can do in terms of PR for this. If anyone in this thread want to beat me to it feel free :-)

HarelM commented 2 years ago

I've opened the following PR: https://github.com/moribvndvs/ng2-idle/pull/169 Besides running the tests is there another way to make sure everything is as expected?