moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

build(deps): upgrade Angular dependencies to v15 #186

Closed un1c0rnr1d3r closed 1 year ago

un1c0rnr1d3r commented 1 year ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) Angular v14 dependencies are in use.

What is the new behavior? Angular dependencies have been upgraded to v15.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

coveralls commented 1 year ago

Coverage Status

Coverage: 100.0%. Remained the same when pulling f73e19e9b67f9176bf4317391d869513802a2ebd on upgrade-deps-angular-15 into 245828108a511ed30319cb4477e212e86944c3ad on master.

moribvndvs commented 1 year ago

@un1c0rnr1d3r The peer dependencies for core and keepalive package.json still have >=9.0.0. Is this update safe for projects that targets those versions still, or do we need to bump these requirements up?

If no, then I can just release this as another patch to v12. If yes, then we'll need to set the minimum version and add that as a breaking change, moving ng-idle to 13.

un1c0rnr1d3r commented 1 year ago

@moribvndvs Technically, Angular does not support building an application using a version older than the one the library was built with. However, I think this release should continue to work (albeit officially unsupported) with Angular v9+.