search

moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
322 stars 129 forks source link

Add support for Angular 17 #195

Closed dsubelman closed 3 months ago

dsubelman commented 10 months ago

Desired functionality

Add support for Angular 17 release.

Now that Angular 17 has been released, are there any plans to release a new version that supports Angular 17?

nehadpfriends commented 8 months ago

Does this module works for Angular 16 ?

moribvndvs commented 8 months ago

Yes, angular 16 support was added in the most recent release.

robinprieschl commented 5 months ago

Are there currently any plans for this? It is currently blocking us from upgrading to Angular 17 for our project.

dmitrye commented 3 months ago

This needs to be upgraded because Angular 17/18 apps not using Zone.js break with "Zone is not defined" due to direct reference in ng-idle-core on line 750 for example.

hey24sheep commented 3 months ago

@moribvndvs Hi, can we please add the support for Angular version 17 & 18. That will be great, we have our project updated to 18 recently and we are currently in build fail due to this package being unsupported :(

hey24sheep commented 3 months ago

@moribvndvs any update? Thanks

msibhuiyan commented 3 months ago

Hi @hey24sheep there are two active PRs for Angular 17 and Angular 18 Can you review the PR whether it works and meets the requirements?

hey24sheep commented 3 months ago

@BhuiyanSaif18 I just reviewed they are migrations only. So, it should work but the release needs to happen through the owner so it can be published on NPM itself. This issue has been open since 2023, I think it's high time to update the packages to support 17 & 18. I request for the update, it is very much needed to upgrade our projects. I don't want to maintain the forks just for the project upgrade.

AHaseebAwan commented 3 months ago

@moribvndvs do you think, we could merge these PRs mentiond by @BhuiyanSaif18? LGTM!

moribvndvs commented 3 months ago

Closed by #200

hey24sheep commented 3 months ago

Hi, I will test the package in a few days, Thanks a bunch everyone and especially @moribvndvs :)