moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

Angular 18 migration #202

Open BhuiyanSaif18 opened 3 days ago

BhuiyanSaif18 commented 3 days ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Other... Please describe: Angular 18 migration

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

coveralls commented 3 days ago

Coverage Status

coverage: 100.0%. remained the same when pulling bfb00ca9e8f0f5c856c66dc25f17521dd13dbdd1 on planally:ng-18 into fc7d369d66d2decfce202ee16f4a26476930c87b on moribvndvs:master.

moribvndvs commented 1 day ago

So @ng-idle/core and keepalive both declare

"@angular/common": ">=17.3.10",
"@angular/core": ">=17.3.10"

as dependencies. Is this version sufficiently breaking that we need to bump these versions as well? I'm thinking maybe we don't since the packages don't export or otherwise rely on 18 specific things, with the exception of tests (which are irrelevant to consumers of these packages).

coveralls commented 15 hours ago

Coverage Status

coverage: 100.0%. remained the same when pulling 250e0c34f7400bf96a5625cb74d5f470c4410033 on planally:ng-18 into fc7d369d66d2decfce202ee16f4a26476930c87b on moribvndvs:master.

BhuiyanSaif18 commented 15 hours ago

@moribvndvs If not major, I believe we could publish a minor version, As the bundle itself goes with the latest version of angular in the docs. In the future, newer version of Angular migration should go smoothly.