moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
322 stars 129 forks source link

Timeout happening on one idle instance is causing the interrupt to stop working on the other idle instance #204

Open vinacharya05 opened 1 month ago

vinacharya05 commented 1 month ago

NOTE: Due to limited time constraints and resources, we ask that you please use Stack Overflow or similar to troubleshoot or ask general questions, and not use bug reports to solicit help setting up your app.

Describe the bug I have two idle instances, one for auto logout and another one for screensaver.

If my screensaver is "Active" and if timeout happens on the first instance(i,e. autologout) and if I try to interrupt the screen then screensaver is not going off and its blocking the UI. (One thing is clear that interrupt subscription stops working in this scenario).

To Reproduce import {Component, NgZone, OnInit} from '@angular/core'; import {DEFAULT_INTERRUPTSOURCES, Idle, LocalStorage, LocalStorageExpiry} from '@ng-idle/core'; @Component({ selector: 'app-root', templateUrl: './app.component.html', styleUrls: ['./app.component.scss'] }) export class AppComponent implements OnInit{ title = 'my-idle-app'; private readonly screenSaver!: HTMLElement; private readonly screenSaverText!: Text; idleTime1: number = 1; private screenSaverIdle = new Idle(new LocalStorageExpiry(new LocalStorage()), this.ngZone);

constructor(readonly ngZone: NgZone, private idle1: Idle) { this.screenSaver = document.createElement('div'); this.screenSaver.id = 'screensaver'; this.screenSaver.className = 'screen-saver'; this.screenSaverText = document.createTextNode('---%'); const movingTxt = document.createElement('span'); movingTxt.appendChild(this.screenSaverText); this.screenSaver.appendChild(movingTxt); this.removeScreenSaver();

this.screenSaverIdle.setIdleName('screenSaverIdleService');
this.screenSaverIdle.setInterrupts(DEFAULT_INTERRUPTSOURCES);
this.screenSaverIdle.setTimeout(false);
this.screenSaverIdle.setIdle(10);
this.screenSaverIdle.watch();

this.screenSaverIdle.onIdleStart.subscribe(() => {
  document.body.appendChild(this.screenSaver);
});

this.screenSaverIdle.onIdleEnd.subscribe(() => {
  console.log('IDLE END ::');
  this.removeScreenSaver();
});

}

ngOnInit() { this.idle1.setIdleName('AutoLogoutIdleService'); this.idle1.setInterrupts(DEFAULT_INTERRUPTSOURCES);

this.idle1.setIdle(this.idleTime1);
this.idle1.setTimeout(10);

this.idle1.onIdleStart.subscribe(() => {
  console.log("IDLE 1 STARTS")
});

this.idle1.onIdleEnd.subscribe({
  next: () => {
    console.log("IDLE 1 END");
  },
  complete: () => {
    console.log("idle 1 completed");
  }
});

this.idle1.onTimeout.subscribe(()=> {
  console.log("User session timed Out",);
});

this.idle1.watch();

}

private removeScreenSaver() { const ex = document.getElementById('screensaver'); if (ex) { document.body.removeChild(ex); } } }

Expected behavior A clear and concise description of what you expected to happen.

Please tell us about your environment

vinacharya05 commented 1 month ago

sample code to reproduce this issue. https://stackblitz.com/edit/angular-13-starter-project-ibwtvf?file=src%2Fapp%2Fapp.component.ts,src%2Findex.html

behdi commented 2 weeks ago

Way too late to answer this, but the reason for this is that you're using DEFAULT_INTERRUPTSOURCES object as the interrupt source for both of your idle instances. As soon as you go idle, the Idle service unsubscribes from the interrupt sources, and since DEFAULT_INTERRUPTSOURCES is an object that's shared between both of your instances, as soon as one instance goes idle, the other one also stops listening to interrupt sources and never reintializes again.

You should use createDefaultInterruptSources() instead.