moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

fix(idle):[On behalf of Lexmark International, Inc] Check expiry on t… #41

Closed markmaynard closed 7 years ago

markmaynard commented 7 years ago

…imeout doCountdown

Check expiry in doCountdown to see if it has changed and if so interrupt. For multi-tab support.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here) Currently when the timeout countdown starts when using multiple tabs dismissing the timeout on one tab does not dismiss the timeout on another tab. When the non-focused tab expires it then logs out both tabs.

What is the new behavior? Dismissing one timeout countdown dismisses all tabs. Allowing user to remain active in all tabs.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 99.336% when pulling ce0dae21624864655c6877cfcda3e56218c67819 on markmaynard:master into 753afad830b2622901d68ef10a7202b27ee0fffb on HackedByChinese:master.