search

moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

Avoid for loops over find output #81

Closed sliekens closed 6 years ago

sliekens commented 6 years ago

I'm submitting a ... (check one with "x")

[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/HackedByChinese/ng2-idle/blob/master/CONTRIBUTING.md#getting-help

Current behavior

The bundle:umd script uses for over find output, which is fragile. https://github.com/koalaman/shellcheck/wiki/SC2044

Expected behavior

The script should use find -exec.

Minimal reproduction of the problem with instructions

Clone the repository to a path that contains spaces and try to run the build.

What is the motivation / use case for changing the behavior?

Windows users are not afraid to have spaces in their paths.

Please tell us about your environment:

Windows 10