moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

chore: use find -exec #82

Closed sliekens closed 6 years ago

sliekens commented 6 years ago

For loops over find output are fragile. Use find -exec or a while read loop.

Resolves #81

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

81

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information: https://github.com/koalaman/shellcheck/wiki/SC2044

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 99.364% when pulling 47532ba61d69855b34774384b9812d1e9c1cb4f6 on StevenLiekens:bugfix/use-find-exec into 7af83e08335f1f733f4ba14ba054dc2309962627 on HackedByChinese:master.