moribvndvs / ng2-idle

Responding to idle users in Angular (not AngularJS) applications.
https://moribvndvs.github.io/ng2-idle
Apache License 2.0
315 stars 128 forks source link

Refactor RxJs usages #83

Closed sliekens closed 6 years ago

sliekens commented 6 years ago

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x")

[x] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

In EventTargetInterruptSource:

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information: I had to fix the formatting a little bit. Someone isn't using EditorConfig.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.01%) to 99.353% when pulling 8b43d17dd4ffa838d0d9bffc3151997141fdbc80 on StevenLiekens:refactor-rxjs-usages into 294f13a95681d4581380ad13843c812478a08ed0 on HackedByChinese:master.

sliekens commented 6 years ago

Coverage decreased (-0.01%) to 99.353%

That's interesting because if you look at the report, the coverage of each file stayed the same or rose.

Apparently the coverage decreased because I refactored EventTargetInterruptSource to require less code to make the tests pass, causing the relative percentage of untested code to increase. This is why I always hated math.